miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

AddPinhole updates to inappropriate Leasetime.

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs
View previous topic :: View next topic  
Author Message
Gval_NEC_Platforms



Joined: 26 Jan 2023
Posts: 8
Location: Japan
PostPosted: Fri Jan 27, 2023 12:22 am    Post subject: AddPinhole updates to inappropriate Leasetime. Reply with quote
I understand the Leasetime would be updated by execution of AddPinhole function on existing entry.
But even though I set few seconds of Leasetime, it takes so long until timeout.

Quote:
upnpc -6 -A "" 0 <ipv6> 5201 udp 10


It seems calculation of Leasetime in miniupnpd/upnppinhole.c:upnp_update_inboundpinhole is wrong as following,

In ver 2.2.3 : <current time> + <current time> + Leasetime
I expected : <current time> + Leasetime

Could anyone help to fix it?
Back to top
View user's profile Send private message Send e-mail
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1594
PostPosted: Sat Jan 28, 2023 2:56 pm    Post subject: Reply with quote
Thank you for the bug report
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1594
PostPosted: Sat Jan 28, 2023 3:59 pm    Post subject: Reply with quote
https://github.com/miniupnp/miniupnp/commit/7bd0877b8fd9a1c1c59cdf426b4640b3cee2bf61
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.