miniupnp.tuxfamily.org

[twear]

The current UPnP standard now only supports IGDv2, v1 has been deprecated.

As a part of this there is 1 main issue that I am seeing. MiniUPnPd needs to respond back to action response with the correct namespace which it was invoked with. Currently it just uses a hardcoded value.

According to the specification:
<actionNameResponse>
REQUIRED. Name of element is action name prepended to Response. xmlns namespace attribute MUST be service type enclosed in double quotes. Devices that support the same action in multiple namespaces MUST use the same namespace in the response as was used in the action invocation. For example, if an action was invoked using namespace:
urn:schemas-upnp-org:service:ContentDirectory:2
The response MUST also use namespace:
urn:schemas-upnp-org:service:ContentDirectory:2

[miniupnp]

the service type is used as namespace.
only in the case of several service supporting the same action it is important to answer with the same namespace as used in invocation.

Is there a precise example of an action responding with a wrong namespace ?
The UPnP Certification test tool is supposed to detect such issues
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/

[twear]

This is the error from CTT:
Missing <GetConnectionTypeInfoResponse> element or invalid namespace in response for the action request: "urn:schemas-upnp-org:service:WANIPConnection:1#GetConnectionTypeInfo"

If IGDv2 is enabled, WANIPC_VERS should be 2. But if an older client sends a request it has no notion of version 2, so it sends the request as above and expects a response with the same version. It looks like all these values are hardcoded in the struct in minissdp though.

Also I had to update the version numbers for WANConnectionDevci and WANDevice. As well as the entry for WANIPv6FirewallControll uses url at the beginning instead of urn...

[miniupnp]

OK I see the problem
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/

[miniupnp]

what about https://github.com/miniupnp/miniupnp/commit/a4b97cf1058145c8b7bb70d2f4cb1d8c1b83d560 ?
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/

[twear]

Patch doesn't apply cleanly to my build right now, I'll update you tomorrow.

[twear]

I am still seeing the same error, I'm trying to look into why.

[miniupnp]

[twear]

yeah, and I haven't had time to look into why. I'll update as soon as I can.

[miniupnp]

any update ?
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/

[usaxena]

Hi,

For the patch provided we had few soap actions missing which had the correct namespace.
Adding them the test case is now passing.

[usaxena]

The patch I am referring is https://github.com/miniupnp/miniupnp/commit/a4b97cf1058145c8b7bb70d2f4cb1d8c1b83d560

[miniupnp]

It was complemented by
https://github.com/miniupnp/miniupnp/commit/1e7b2342fab15a7650851ed97b31d81887940629
and
https://github.com/miniupnp/miniupnp/commit/92cc93f6f8423b3713bf2bf28ac17da26b054ef3
please test using latest source code.
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/