miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Request with unspecified Ports should not be accepted

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs
View previous topic :: View next topic  
Author Message
Gval_NEC_Platforms



Joined: 26 Jan 2023
Posts: 8
Location: Japan
PostPosted: Fri Jan 27, 2023 12:18 am    Post subject: Request with unspecified Ports should not be accepted Reply with quote
In UPnP-gw-WANIPv6FirewallControl-v1-Service-20101210.pdf section 2.6.3.2, RemotePort and InternalPort have type of ui2.
And from definition of ui2 in section 2.4.6 of same document, just "0" is the wildcard value for this valuable.

Against the document, miniupnpd accepts the request which doesn't decide RemortPort(InternalPort) number, and set it as wildcard.
For example, using upnpc,

Quote:
upnpc -6 -A "" "" <ipv6> 5201 tcp 1000


Client sends request with no RemotePort value like <RemotePort></RemotePort> by the command.
miniupnpd accepts this request and let entry of Pinhole, and set RemortPort as wildcard.

I believe RemotePort(Internal Port) have to be specified as number among 0~65535.
So in my opinion, request with unspecified Ports should not be accepted.
If I had misunderstanding, please let me know.
Back to top
View user's profile Send private message Send e-mail
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1594
PostPosted: Sat Jan 28, 2023 2:49 pm    Post subject: Reply with quote
You are right, I'm going to add code to reject such requests when miniupnp is compiled with UPNP_STRICT option
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1594
PostPosted: Sat Jan 28, 2023 3:57 pm    Post subject: Reply with quote
https://github.com/miniupnp/miniupnp/commit/57ae40fe108d956ca5a0770f03aefac2922a40e8
_________________
Main miniUPnP author.
https://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.