miniupnp.tuxfamily.org

jinschoi · Joined: 11 Apr 2010 Posts: 5

I was trying to debug why miniupnp could not adjust the port forwardings on my Linksys WRT610N. After some playing around with upnpc, I determined that the router only accepts HTTP/1.1, and returns nothing on HTTP/1.0 requests. Changing all HTTP requests to version 1.1 made it work as expected.

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

Well that's a problem because only HTTP/1.0 is properly implemented in miniupnpc.

In order to support HTTP/1.1, chunked transfert encoding should be implemented.
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/

jinschoi · Joined: 11 Apr 2010 Posts: 5

I understand the concern about not "properly" implementing HTTP/1.1, but I would venture a guess that to a first approximation 0% of routers would use chunked transfer encoding. I have no data to support this, though.

Would it be too terrible to retry with HTTP/1.1 after a failed HTTP/1.0 request, and reject any chunked transfer encoding responses? It would be an easy fix, wouldn't break for any routers which work now, and would allow use of miniupnp for Linksys routers, of which there are a great many out there.

I'm not sure whether this problem affects all Linksys routers, or just those with the latest firmware, but even if it were just the latest firmware, it will become more of an issue as it becomes more widespread. We could also ask Linksys to accept HTTP/1.0 going forward.

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

jinschoi · Joined: 11 Apr 2010 Posts: 5

Okay. What about my idea of trying 1.1 only if 1.0 fails? That would be just a few lines of code, and would keep those chunked transfer routers working as well.

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

jinschoi · Joined: 11 Apr 2010 Posts: 5

Okay, here's my patch. Tries HTTP/1.0, falls back to HTTP/1.1 if nothing is returned. Works for me, though it has the downside of doubling the number of queries for routers that have this problem. Should have no effect on routers for which it currently works.

Of course, you're right it should do chunked transfer encoding for real, but that's too much work for me right now.... What about using a full featured HTTP library? Would it bulk up the code size too much?

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

Thanks a lot for the patch !
miniupnpc-1.4.20100412.tar.gz
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

miniupnp · Site Admin Joined: 14 Apr 2007 Posts: 1536

hello, I implemented the chunked transfer encoding.
Could you check if that works properly with the Bipac routers ?

thank you

miniupnpc-1.4.20101209.tar.gz
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/

jinschoi · Joined: 11 Apr 2010 Posts: 5

I don't know about Bipac, but it no longer works for Cisco/Linksys routers again.

edit: Okay, I've gone back and tried it with hand-generated requests, and old versions of the code, and I've determined that it's fine. Cisco/Linksys routers can apparently only have 32 redirects, and attempts to add more result in a 402 invalid args error.