View previous topic :: View next topic |
Author |
Message |
pgk
Joined: 28 Apr 2011 Posts: 12
|
Posted: Tue May 10, 2011 7:54 am Post subject: Deleting filter rules |
|
|
Hi,
In delete_redirect_and_filter_rules() function , the function
delete_rule_and_commit() for filter table is not getting invoked at all.
it is not required ? _________________ Best Regards,
PGK |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
Posted: Wed May 11, 2011 7:16 pm Post subject: Re: Deleting filter rules |
|
|
pgk wrote: | Hi,
In delete_redirect_and_filter_rules() function , the function
delete_rule_and_commit() for filter table is not getting invoked at all.
it is not required ? |
it is called. which version of the file are you talking about ? _________________ Main miniUPnP author.
https://miniupnp.tuxfamily.org/ |
|
Back to top |
|
|
pgk
Joined: 28 Apr 2011 Posts: 12
|
Posted: Thu May 12, 2011 5:43 am Post subject: |
|
|
Hi ,
I have taken release SDK miniupnpd-1.5.tar.gz
Below is the file version
/* $Id: iptcrdr.c,v 1.33 2010/09/27 09:17:59 nanard Exp $ */
delete_rule_and_commit() with nat as argument returns 0 on success , now 0 logical AND with one more function is not evaluated , so one more function is not called ... am i right ? _________________ Best Regards,
PGK |
|
Back to top |
|
|
pgk
Joined: 28 Apr 2011 Posts: 12
|
Posted: Thu May 12, 2011 12:10 pm Post subject: Some queries for test cases |
|
|
Hi,
Below test cases are failing with miniupnp. I am running UPnP test cases with software test tool "CDROUTER"
1. +FAIL Verify dynamic UPnP port mapping is deleted when lease expires
2. +FAIL Verify UPnP clients can renew NOTIFY events for WANIPConnection or WANPPPConnection
3. +FAIL Verify router sends UPnP NOTIFY events for ConnectionStatus
4. +FAIL Verify router sends UPnP NOTIFY events with updated ExternalIPAddress
5. +FAIL Verify the maximum number of UPnP event subscriptions that can be created
I have enabled "#define ENABLE_EVENTS" in config.h.
I am having your release SDK miniupnpd-1.5.tar.gz
Could you please help me ..? _________________ Best Regards,
PGK |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
|
Back to top |
|
|
pgk
Joined: 28 Apr 2011 Posts: 12
|
Posted: Fri May 13, 2011 4:56 am Post subject: |
|
|
Hi,
Thank you very much.
[ Below test cases are failing with miniupnp. I am running UPnP test cases with software test tool "CDROUTER"
1. +FAIL Verify dynamic UPnP port mapping is deleted when lease expires
2. +FAIL Verify UPnP clients can renew NOTIFY events for WANIPConnection or WANPPPConnection
3. +FAIL Verify router sends UPnP NOTIFY events for ConnectionStatus
4. +FAIL Verify router sends UPnP NOTIFY events with updated ExternalIPAddress
5. +FAIL Verify the maximum number of UPnP event subscriptions that can be created
I have enabled "#define ENABLE_EVENTS" in config.h. ]
Also please help me for the above test cases too. _________________ Best Regards,
PGK |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
Posted: Fri May 13, 2011 10:01 am Post subject: |
|
|
pgk wrote: |
1. +FAIL Verify dynamic UPnP port mapping is deleted when lease expires
|
yes, lease expiration is still not implemented correctly in miniupnpd. It is on the todo list (it is mandatory to support IGDv2, it was useless in IGDv1)
pgk wrote: |
2. +FAIL Verify UPnP clients can renew NOTIFY events for WANIPConnection or WANPPPConnection
3. +FAIL Verify router sends UPnP NOTIFY events for ConnectionStatus
4. +FAIL Verify router sends UPnP NOTIFY events with updated ExternalIPAddress
5. +FAIL Verify the maximum number of UPnP event subscriptions that can be created
|
I need more details on the tests themselves to understand exactly what is wrong... _________________ Main miniUPnP author.
https://miniupnp.tuxfamily.org/ |
|
Back to top |
|
|
pgk
Joined: 28 Apr 2011 Posts: 12
|
Posted: Mon May 16, 2011 2:23 pm Post subject: |
|
|
Hi,
3. +FAIL Verify router sends UPnP NOTIFY events for ConnectionStatus
Below steps the test tool is going through.
Till step5 it is fine. From step6 once it brought down WAN link,
it is not receiving new NOTIFY for ConnectionStatus.and Test case fails.
step 1. Find Control URL for WANIPConnection or WANPPPConnection service
step 2. Send SUBSCRIBE for eventSubURL
step 3. Verify SUBSCRIBE returns HTTP 200 OK response
step 4. Wait for initial NOTIFY event
step 5. Verify ConnectionStatus is 'Connected'
step 6. Bring down WAN link
step 7. Wait for NOTIFY event with new ConnectionStatus
step 8. Verify ConnectionStatus is not 'Connected'
step 9. Bring up WAN link
step 10. Wait for NOTIFY event with new ConnectionStatus
step 11. Verify ConnectionStatus is 'Connected'
step 12. Send UNSUBSCRIBE for eventSubURL
step 13. Verify UNSUBSCRIBE returns HTTP 200 OK reponse
4. +FAIL| Verify router sends UPnP NOTIFY events with updated ExternalIPAddress
Till step5 it is fine. From step6 once it bring down and up WAN link with external IP address,
it is not receiving NOTIFY with new ExternalIPAddress and Test case fails.
step 1. Find Control URL for WANIPConnection or WANPPPConnection service
step 2. Send SUBSCRIBE for eventSubURL
step 3. Verify SUBSCRIBE returns HTTP 200 OK response
step 4. Wait for initial NOTIFY event
step 5. Verify ExternalIPAddress matches current assigned WAN IP
step 6. Bring down WAN link
step 7. Bring up WAN link with new external IP address
step 8. Wait for NOTIFY event with new ExternalIPAddress
step 9. Verify ExternalIPAddress is new IP address
step 10. Bring down WAN link
step 11. Bring up WAN link with new original IP address
step 12. Wait for NOTIFY event with new ExternalIPAddress
step 13. Verify ExternalIPAddress is original IP address
step 14. Send UNSUBSCRIBE for eventSubURL
step 15. Verify UNSUBSCRIBE returns HTTP 200 OK reponse
5. +FAIL| Verify the maximum number of UPnP event subscriptions that can be created
Here also same as 3. test case , till step6 it is fine. after that it fails.
step 1. Find Control URL for WANIPConnection or WANPPPConnection service
step 2. For each event client, send SUBSCRIBE for eventSubURL
step 3. Verify SUBSCRIBE returns HTTP 200 OK response
step 4. For each event client, wait for initial NOTIFY event
step 5. Verify ConnectionStatus is 'Connected'
step 6. Bring down WAN link
step 7. For each event client, wait for NOTIFY event with new ConnectionStatus
step 8. For each event client, verify ConnectionStatus is not 'Connected'
step 9. Bring up WAN link
step 10. For each event client, wait for NOTIFY event with new ConnectionStatus
step 11. For each event client, verify ConnectionStatus is 'Connected'
step 12. For each event client, send UNSUBSCRIBE for eventSubURL
step 13. For each event client, verify UNSUBSCRIBE returns HTTP 200 OK reponse
Please let me know with the above test cases and help me. _________________ Best Regards,
PGK |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
Posted: Mon May 16, 2011 3:32 pm Post subject: |
|
|
thank you for the details.
ConnectionStatus is always set to "Connected". I would need a way to detect that the wan is disconected...
ExternalIPAddress => OK But miniupnpd doesnt detect by itself the IP changed. So you need to send the signal USR1 to miniupnpd when the ip change.
Code: | kill -USR1 `cat /var/run/miniupnpd.pid` |
_________________ Main miniUPnP author.
https://miniupnp.tuxfamily.org/ |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1589
|
|
Back to top |
|
|
|