miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Issue in 1.5.20110520

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs
View previous topic :: View next topic  
Author Message
SoLoR



Joined: 30 May 2009
Posts: 36

PostPosted: Wed May 25, 2011 7:05 pm    Post subject: Issue in 1.5.20110520 Reply with quote

I "think" this started in 1.5.20110520 or maybe it was in 1.5.20110519 and i didnt notice anyway... following type of errors in syslog after a day or two of runing miniupnpd:

Code:
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: accept(http): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: socket(PF_INET, SOCK_DGRAM): Too many open files
May 25 19:37:14 mih miniupnpd[7468]: Failed to get ip address for interface eth0
May 25 19:37:14 mih miniupnpd[7468]: get_redirect_rule() : iptc_init() failed : Too many open files
May 25 19:37:14 mih miniupnpd[7468]: addnatrule() : iptc_init() error : Too many open files
May 25 19:37:14 mih miniupnpd[7468]: delete_redirect_and_filter_rules() : iptc_init() failed : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: socket(PF_INET, SOCK_DGRAM): Too many open files
May 25 19:46:04 mih miniupnpd[7468]: socket(PF_INET, SOCK_DGRAM): Too many open files
May 25 19:46:04 mih miniupnpd[7468]: get_redirect_rule() : iptc_init() failed : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: get_redirect_rule() : iptc_init() failed : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: addnatrule() : iptc_init() error : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: socket(PF_INET, SOCK_DGRAM): Too many open files
May 25 19:46:04 mih miniupnpd[7468]: socket(PF_INET, SOCK_DGRAM): Too many open files
May 25 19:46:04 mih miniupnpd[7468]: get_redirect_rule() : iptc_init() failed : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: get_redirect_rule() : iptc_init() failed : Too many open files
May 25 19:46:04 mih miniupnpd[7468]: addnatrule() : iptc_init() error : Too many open files
...
...


it starts with "* miniupnpd[7468]: accept(http): Too many open files" after you get repeatable other errors on each redirection....

anyway lsof show following:

Code:
mih ~ # lsof | grep miniupnpd
miniupnpd  7468         root  cwd       DIR        8,3      4096          2 /
miniupnpd  7468         root  rtd       DIR        8,3      4096          2 /
miniupnpd  7468         root  txt       REG        8,3     67288    1053264 /usr/sbin/miniupnpd
miniupnpd  7468         root  mem       REG        8,3   1380764    1066104 /lib/libc-2.13.so
miniupnpd  7468         root  mem       REG        8,3     21760    1052094 /lib/libip4tc.so.0.0.0
miniupnpd  7468         root  mem       REG        8,3    117748    1066034 /lib/ld-2.13.so
miniupnpd  7468         root    0u      CHR        1,3       0t0         91 /dev/null
miniupnpd  7468         root    1u      CHR        1,3       0t0         91 /dev/null
miniupnpd  7468         root    2u      CHR        1,3       0t0         91 /dev/null
miniupnpd  7468         root    3u     unix 0xf43aa280       0t0      16800 socket
miniupnpd  7468         root    4u     IPv4      16805       0t0        TCP *:45569 (LISTEN)
miniupnpd  7468         root    5u     IPv4      16806       0t0        UDP *:1900
miniupnpd  7468         root    6u     IPv4      16807       0t0        UDP mih.local.mihgroup.eu.org:48118
miniupnpd  7468         root    7u     sock        0,5       0t0      16808 can't identify protocol
miniupnpd  7468         root    9r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   10r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   11r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   12r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   13r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   14r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   15r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   16r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   17r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   18r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   19r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   20r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   21r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   22r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   23r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   24r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   25r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   26r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
miniupnpd  7468         root   27r      REG       0,11      4096       7947 /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0b.0/net/eth0/speed
....
....


last line is repeatable few hundred times, i guess until it reaches limit of open files per process and then it starts to error out in syslog.


im reverting back to 1.5.20110519, ill see tomorrow if error will show again.


OS: Linux.


Last edited by SoLoR on Wed May 25, 2011 7:42 pm; edited 2 times in total
Back to top
View user's profile Send private message
SoLoR



Joined: 30 May 2009
Posts: 36

PostPosted: Wed May 25, 2011 7:28 pm    Post subject: Reply with quote

ok here is difference between lsof of freshly started miniupnpd deamons:

1.5.20110519
Code:
mih ~ # lsof | grep miniupnpd
miniupnpd 19679         root  cwd       DIR        8,3      4096          2 /
miniupnpd 19679         root  rtd       DIR        8,3      4096          2 /
miniupnpd 19679         root  txt       REG        8,3     67256     394343 /usr/sbin/miniupnpd
miniupnpd 19679         root  mem       REG        8,3   1380764    1066104 /lib/libc-2.13.so
miniupnpd 19679         root  mem       REG        8,3     21760    1052094 /lib/libip4tc.so.0.0.0
miniupnpd 19679         root  mem       REG        8,3    117748    1066034 /lib/ld-2.13.so
miniupnpd 19679         root    0u      CHR        1,3       0t0         91 /dev/null
miniupnpd 19679         root    1u      CHR        1,3       0t0         91 /dev/null
miniupnpd 19679         root    2u      CHR        1,3       0t0         91 /dev/null
miniupnpd 19679         root    3u     unix 0xf43aa280       0t0     151493 socket
miniupnpd 19679         root    4u     IPv4     151496       0t0        TCP *:56023 (LISTEN)
miniupnpd 19679         root    5u     IPv4     151497       0t0        UDP *:1900
miniupnpd 19679         root    6u     IPv4     151498       0t0        UDP mih.local.mihgroup.eu.org:46566


1.5.20110520
Code:
mih ~ # lsof | grep miniupnpd
miniupnpd 17395         root  cwd       DIR        8,3      4096          2 /
miniupnpd 17395         root  rtd       DIR        8,3      4096          2 /
miniupnpd 17395         root  txt       REG        8,3     67288     394378 /usr/sbin/miniupnpd
miniupnpd 17395         root  mem       REG        8,3   1380764    1066104 /lib/libc-2.13.so
miniupnpd 17395         root  mem       REG        8,3     21760    1052094 /lib/libip4tc.so.0.0.0
miniupnpd 17395         root  mem       REG        8,3    117748    1066034 /lib/ld-2.13.so
miniupnpd 17395         root    0u      CHR        1,3       0t0         91 /dev/null
miniupnpd 17395         root    1u      CHR        1,3       0t0         91 /dev/null
miniupnpd 17395         root    2u      CHR        1,3       0t0         91 /dev/null
miniupnpd 17395         root    3u     unix 0xf43aa480       0t0     142149 socket
miniupnpd 17395         root    4u     IPv4     142152       0t0        TCP *:33632 (LISTEN)
miniupnpd 17395         root    5u     IPv4     142153       0t0        UDP *:1900
miniupnpd 17395         root    6u     IPv4     142154       0t0        UDP mih.local.mihgroup.eu.org:57259
[b]miniupnpd 17395         root    7u     sock        0,5       0t0     142155 can't identify protocol[/b]


i think that bold opened socket in 1.5.20110520 eventually bugs out....
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1518

PostPosted: Wed May 25, 2011 10:21 pm    Post subject: Reply with quote

I think I found :
Code:
Index: linux/getifstats.c
===================================================================
RCS file: /usr/local/cvsroot/miniupnp/miniupnpd/linux/getifstats.c,v
retrieving revision 1.8
diff -u -r1.8 getifstats.c
--- linux/getifstats.c  16 May 2011 16:46:06 -0000      1.8
+++ linux/getifstats.c  25 May 2011 22:21:25 -0000
@@ -93,6 +93,7 @@
                if(fgets(line, sizeof(line), f)) {
                        data->baudrate = 1000000*atoi(line);
                }
+               fclose(f);
        } else {
                syslog(LOG_WARNING, "cannot read %s file : %m", fname);
        }

_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
SoLoR



Joined: 30 May 2009
Posts: 36

PostPosted: Wed May 25, 2011 10:30 pm    Post subject: Reply with quote

miniupnp wrote:
I think I found :


im trying this patch.... it will probably take at least a day or two to see if problem went away....

there is still that sock open that is not in 20110519

Code:
miniupnpd 25662         root    7u     sock        0,5       0t0     239401 can't identify protocol


but problem is if bug reapears or not... ill report back in a day or two.
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1518

PostPosted: Thu May 26, 2011 8:39 pm    Post subject: Reply with quote

SoLoR wrote:
miniupnp wrote:
I think I found :


im trying this patch.... it will probably take at least a day or two to see if problem went away....

there is still that sock open that is not in 20110519

Code:
miniupnpd 25662         root    7u     sock        0,5       0t0     239401 can't identify protocol


but problem is if bug reapears or not... ill report back in a day or two.

That socket is for network interface address change detection.
See the OpenAndConfInterfaceWatchSocket() function in linux/ifacewatcher.c
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
SoLoR



Joined: 30 May 2009
Posts: 36

PostPosted: Fri May 27, 2011 5:21 pm    Post subject: Reply with quote

just to report back... that fclose(f); seems to fixes this problem... no issue for last day and a half...
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.