| View previous topic :: View next topic |
| Author |
Message |
fest3er
Joined: 23 Apr 2013
Posts: 2
|
 Posted: Tue Apr 23, 2013 8:18 pm Post subject: Minor makefile problem |
 |
|
The build (for version 1.7, building on Linux in my case) needs a bit of attention. When using parallel make (e.g., '-j 4'), the configure and the compile run in parallel. This can result in the failure of an automated build; but it doesn't always result in failure. Technically it's a race condition.
A uniprocessor system should never have this error because all the build steps run sequentially. My quad Phenom-II (using '-j 4') never produced it, possibly because genconfig finished before make ever noticed that config.h existed. It appeared yesterday on a system that runs automated daily builds (after building without error for a couple months). In this failure, config.h was only partially written. I have added an explicit configure step that will (obviously) prevent this failure.
The instructions in INSTALL are not faulty; they do say to configure, then edit config.h as needed. But my automated build system patches the sources so that editing is not needed.
I think it may suffice to change genconfig.sh to prepare config.h in a temporary file (maybe config.h.tmp), then rename it to config.h only after it is complete; this should prevent make from proceeding the instant it sees an empty or partially written config.h. |
|
| Back to top |
|
 |
miniupnp
Site Admin
Joined: 14 Apr 2007
Posts: 1589
|
|
| Back to top |
|
|
fest3er
Joined: 23 Apr 2013
Posts: 2
|
| Posted: Wed Apr 24, 2013 5:37 pm Post subject: |
|
|
Fast service! Thanks!
N |
|
| Back to top |
|
|
|
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
