miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

UPnP Certification Test Updates

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs
View previous topic :: View next topic  
Author Message
twear



Joined: 01 Nov 2012
Posts: 80

PostPosted: Tue Sep 01, 2015 9:03 pm    Post subject: UPnP Certification Test Updates Reply with quote

The current UPnP standard now only supports IGDv2, v1 has been deprecated.

As a part of this there is 1 main issue that I am seeing. MiniUPnPd needs to respond back to action response with the correct namespace which it was invoked with. Currently it just uses a hardcoded value.

According to the specification:
<actionNameResponse>
REQUIRED. Name of element is action name prepended to Response. xmlns namespace attribute MUST be service type enclosed in double quotes. Devices that support the same action in multiple namespaces MUST use the same namespace in the response as was used in the action invocation. For example, if an action was invoked using namespace:
urn:schemas-upnp-org:service:ContentDirectory:2
The response MUST also use namespace:
urn:schemas-upnp-org:service:ContentDirectory:2
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Wed Sep 02, 2015 10:37 am    Post subject: Reply with quote

the service type is used as namespace.
only in the case of several service supporting the same action it is important to answer with the same namespace as used in invocation.

Is there a precise example of an action responding with a wrong namespace ?
The UPnP Certification test tool is supposed to detect such issues
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
twear



Joined: 01 Nov 2012
Posts: 80

PostPosted: Mon Sep 14, 2015 8:58 pm    Post subject: Reply with quote

This is the error from CTT:
Missing <GetConnectionTypeInfoResponse> element or invalid namespace in response for the action request: "urn:schemas-upnp-org:service:WANIPConnection:1#GetConnectionTypeInfo"

If IGDv2 is enabled, WANIPC_VERS should be 2. But if an older client sends a request it has no notion of version 2, so it sends the request as above and expects a response with the same version. It looks like all these values are hardcoded in the struct in minissdp though.

Also I had to update the version numbers for WANConnectionDevci and WANDevice. As well as the entry for WANIPv6FirewallControll uses url at the beginning instead of urn...
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Mon Sep 14, 2015 9:37 pm    Post subject: Reply with quote

OK I see the problem
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Mon Sep 14, 2015 10:03 pm    Post subject: Reply with quote

what about https://github.com/miniupnp/miniupnp/commit/a4b97cf1058145c8b7bb70d2f4cb1d8c1b83d560 ?
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
twear



Joined: 01 Nov 2012
Posts: 80

PostPosted: Tue Sep 15, 2015 12:56 am    Post subject: Reply with quote

Patch doesn't apply cleanly to my build right now, I'll update you tomorrow.
Back to top
View user's profile Send private message
twear



Joined: 01 Nov 2012
Posts: 80

PostPosted: Wed Sep 16, 2015 4:24 pm    Post subject: Reply with quote

I am still seeing the same error, I'm trying to look into why.
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Fri Sep 18, 2015 12:25 pm    Post subject: Reply with quote

twear wrote:
I am still seeing the same error, I'm trying to look into why.

you mean it is still resonding with urn:schemas-upnp-org:service:WANIPConnection:1 Namespace even if the request was using version 2 ?
Please note that the namespace is copied from the Action: HTTP header, not from the XML payload.
What is your SOAP request, exactly ? (including the HTTP headers)
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
twear



Joined: 01 Nov 2012
Posts: 80

PostPosted: Wed Oct 07, 2015 9:27 pm    Post subject: Reply with quote

yeah, and I haven't had time to look into why. I'll update as soon as I can.
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Sun Oct 25, 2015 8:14 pm    Post subject: Reply with quote

any update ?
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
usaxena



Joined: 23 Dec 2015
Posts: 2
Location: Hyderabad, India

PostPosted: Wed Dec 23, 2015 11:25 am    Post subject: Reply with quote

Hi,

For the patch provided we had few soap actions missing which had the correct namespace.
Adding them the test case is now passing.
Back to top
View user's profile Send private message
usaxena



Joined: 23 Dec 2015
Posts: 2
Location: Hyderabad, India

PostPosted: Wed Dec 23, 2015 11:25 am    Post subject: Reply with quote

The patch I am referring is https://github.com/miniupnp/miniupnp/commit/a4b97cf1058145c8b7bb70d2f4cb1d8c1b83d560
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1442

PostPosted: Wed Dec 30, 2015 9:05 pm    Post subject: Reply with quote

It was complemented by
https://github.com/miniupnp/miniupnp/commit/1e7b2342fab15a7650851ed97b31d81887940629
and
https://github.com/miniupnp/miniupnp/commit/92cc93f6f8423b3713bf2bf28ac17da26b054ef3
please test using latest source code.
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.