View previous topic :: View next topic |
Author |
Message |
somercet
Joined: 09 Sep 2020 Posts: 2 Location: Michigan, USA
|
Posted: Thu Sep 10, 2020 9:45 am Post subject: Xchat miniupnpc patch updated for Hexchat |
|
|
I updated your Xchat patch to work on Hexchat 2.14.2. I successfully used it to receive a file sent by a bot over DCC. Hexchat is a forked, maintained, UTF-8-based descendant of Xchat.
I used the default Arch package for miniupnpc, 2.1.20191224. (I thought there was a newer version, but I was wrong.) Updating the patch from autoconf to Meson/Ninja was a trip.
I'd like to eventually push the code to the Hexchat devs, which will involve conditional compiling, which will need changes to Meson and to upnp.h, so that absent code is not run. Is that okay?
Thanks for the program! |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1593
|
Posted: Sun Sep 20, 2020 1:37 pm Post subject: Re: Xchat miniupnpc patch updated for Hexchat |
|
|
somercet wrote: | I updated your Xchat patch to work on Hexchat 2.14.2. I successfully used it to receive a file sent by a bot over DCC. Hexchat is a forked, maintained, UTF-8-based descendant of Xchat.
I used the default Arch package for miniupnpc, 2.1.20191224. (I thought there was a newer version, but I was wrong.) Updating the patch from autoconf to Meson/Ninja was a trip.
I'd like to eventually push the code to the Hexchat devs, which will involve conditional compiling, which will need changes to Meson and to upnp.h, so that absent code is not run. Is that okay?
Thanks for the program! |
yes, it will be great for hexchat to have built in UPnP support ! _________________ Main miniUPnP author.
https://miniupnp.tuxfamily.org/ |
|
Back to top |
|
|
somercet
Joined: 09 Sep 2020 Posts: 2 Location: Michigan, USA
|
Posted: Sat Mar 19, 2022 3:52 pm Post subject: Hexchat and miniupnpc |
|
|
Hope you don't mind pastebin:
https://pastebin.com/TwZpkurz
https://github.com/somercet/hexchat/tree/miniupnpc
The meson changes allow Hexchat (2.16) to build with miniupnpc if it is present. I have not tested it a lot, but it seems to work.
One possible issue: a number of the miniupnpc functions changed since the original patch. One such change is the scope_id variable. I set it to one, which seems to be a decent default. But I am not on an IPv6 ISP to test it. Was I correct?
One question I have is, should Hexchat test if it is on a NAT IP address? (I.e., 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16, or fd00::/8, not to mention the link-local addresses 169.254.0.0/16 and fe80::/10.) Or does miniupnpc do it?
Sadly, the Hexchat devs seem content to let IRC die. They are also unwilling to upgrade Hexchat to GTK3. Admittedly, this seems to be a huge chore, as several widgets in HC are built in raw GDK, using functions no longer available in GTK3.
A large portion of the user base seems pretty down on any change as well. I mentioned getting UPnP to work in HC, and my hopes that it would one day be ported to GTK3, and someone said, "if it gets updated, I will stop using it."
Ouch. In a world of corporate tech giant censorship, this seems unwise. I am considering updating it myself.
Anyway, thanks for listening!
-p |
|
Back to top |
|
|
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1593
|
|
Back to top |
|
|
|
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
© 2007 Thomas Bernard, author of MiniUPNP.
|