miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Spec bug in natpmp.h

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> libnatpmp Bugs
View previous topic :: View next topic  
Author Message
Chinstrap



Joined: 08 Dec 2007
Posts: 6

PostPosted: Thu Dec 13, 2007 1:59 am    Post subject: Spec bug in natpmp.h Reply with quote

Small (but important) bug in natpmp.h

From natpmp.h:
/* Values to pass to sendnewportmappingrequest() */
#define NATPMP_PROTOCOL_TCP (1)
#define NATPMP_PROTOCOL_UDP (2)


From http://files.dns-sd.org/draft-cheshire-nat-pmp.txt

Opcodes supported:
1 - Map UDP
2 - Map TCP


You got them reversed. I'd post a patch, but I bet you can figure it out pretty easily Smile

Cheers.
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1488

PostPosted: Thu Dec 13, 2007 2:55 pm    Post subject: Reply with quote

important indeed !
thanks for the report.
fixed version will soon be available !
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> libnatpmp Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.