miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Socket bugs

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpc Bugs
View previous topic :: View next topic  
Author Message
lowerpower



Joined: 01 Oct 2007
Posts: 8

PostPosted: Fri Nov 02, 2007 1:34 am    Post subject: Socket bugs Reply with quote

in miniwget2 if the connect fails you leak a socket descriptor resource by not calling closesocket(s)

I think you do this in a few other places.

I think your supposto call closesocket(sd) any time you get a valid socket from socket() even if the connect fails.

probably not real critical in real machines but in uClinux it can be fatal.



-M
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1525

PostPosted: Fri Nov 02, 2007 2:12 pm    Post subject: Reply with quote

indeed there are some socket leaks in this code.
I'm going to fix that.

Thanks for your report
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1525

PostPosted: Wed Jan 09, 2008 11:19 am    Post subject: Reply with quote

fixed since miniupnpc-1.0-RC12
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpc Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.