View previous topic :: View next topic |
Author |
Message |
Charles
Joined: 06 Nov 2007 Posts: 20
|
Posted: Thu Jul 17, 2008 7:57 pm Post subject: minor clang "dead store" warning |
|
|
A Transmission user recently ran the Clang static code analyzer on its code. It generated a few warnings on my own code, and also a very minor miniupnpc warning. In fact it's so minor I hesitate to report it, but I figured I'd you'd enjoy knowing that Clang liked the rest of miniupnpc.
Basically the variable `soapbodylen' is assigned on miniupnp.c:161 but never read because soapbodylen is only used in the `else' branch that follows that section. Here is a patch that fixes the warning by moving soapbodylen's scope down into that `else' branch. |
|
Back to top |
|
 |
miniupnp Site Admin
Joined: 14 Apr 2007 Posts: 1525
|
|
Back to top |
|
 |
|