miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Bug in updateminiupnpstrings.sh

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpc Bugs
View previous topic :: View next topic  
Author Message
Charles



Joined: 06 Nov 2007
Posts: 20

PostPosted: Tue Jul 28, 2009 5:23 pm    Post subject: Bug in updateminiupnpstrings.sh Reply with quote

From http://trac.transmissionbt.com/ticket/2296:

Quote:
The script uses sed substitution to replace the dummy version in the template header, and since the substitution uses / as delimiter, it naturally breaks when the version string contains a /.

A quick fix is to use a different delimiter, like |. Of course, that will fail if some OS happens to have a | in the version string, but I don't think there's any safe character to use (is there a naming policy somewhere?). It would probably be better to do it similar to the update-version-h.sh script.

I'm attaching the quickfix mentioned above, and I also took the liberty of removing the useless use of cat.
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1525

PostPosted: Wed Jul 29, 2009 8:28 am    Post subject: Reply with quote

Thank you for the bug report
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpc Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.