miniupnp.tuxfamily.org Forum Index miniupnp.tuxfamily.org
The forum about miniupnp and libnatpmp
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Question on miniupnpd.conf

 
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Compilation/Installation
View previous topic :: View next topic  
Author Message
a_big_friend



Joined: 22 Jul 2011
Posts: 3

PostPosted: Sun Feb 12, 2012 9:49 am    Post subject: Question on miniupnpd.conf Reply with quote

I see that in one build of wive-ng-rtnl, that uses miniupnp, in the miniupnpd.conf was used the following rule:

allow 1024-65535 192.168.1.1/255.255.255.0 1024-65535

Do you think it is ok expressing the IP/MASK as 192.168.1.1/255.255.255.0 or it should had been used instead the format 192.168.1.1/24

as in:

allow 1024-65535 192.168.1.1/24 1024-65535
Back to top
View user's profile Send private message
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1477

PostPosted: Sun Feb 12, 2012 12:38 pm    Post subject: Reply with quote

The only correct syntax is
Code:
allow 1024-65535 192.168.1.1/24 1024-65535

I should make it more clear
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
miniupnp
Site Admin


Joined: 14 Apr 2007
Posts: 1477

PostPosted: Tue Feb 14, 2012 9:46 am    Post subject: Reply with quote

I updated the code an added more checks : https://github.com/miniupnp/miniupnp/commit/0cc68c47b65cb4dcb5ce4ed0ef2fd991dd6ad297

Maybe I should add the code to parse the form 1.2.3.4/255.255.255.0 after all... if it is already used by some people.
_________________
Main miniUPnP author.
http://miniupnp.tuxfamily.org/
Back to top
View user's profile Send private message Visit poster's website
a_big_friend



Joined: 22 Jul 2011
Posts: 3

PostPosted: Wed Feb 15, 2012 3:01 pm    Post subject: Reply with quote

miniupnp wrote:


Maybe I should add the code to parse the form 1.2.3.4/255.255.255.0 after all... if it is already used by some people.


That would be a good idea. After my ticket on this syntax error, I see that the maintainer of wive-ng-rtnl has patched in his repository miniupnpd sources to be able to parse also the format 1.2.3.4/255.255.255.0

http://gitorious.org/wive-rtnl-ralink-rt305x-routers-firmware/wive-rtnl-ralink-rt305x-routers-firmware/commit/617e9555ee6481c802e07c62fc157796505e1023
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    miniupnp.tuxfamily.org Forum Index -> miniupnpd Compilation/Installation All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP
© 2007 Thomas Bernard, author of MiniUPNP.